pset: mask pegin/issuance flags out of the input outpoint - #293
Open
delta1 wants to merge 1 commit into
Open
Conversation
The pegin and issuance flags are stored in the high bits of the PSET `previous_output_index`, but they are not part of the outpoint itself: Elements Core keeps them separate in memory and only re-adds them when serializing. `Input::issuance_ids` was computing the asset entropy over the flagged index, so any new issuance round-tripped through a PSET derived different asset and token IDs than `TxIn::issuance_ids` and than Elements Core does. Those IDs also feed the blinding code. `extract_tx` already masked the flags, but did so inline. Add `Input::previous_outpoint`, which strips them (leaving the all-1's coinbase index alone, as it carries no flags), and use it from both places so the two cannot drift apart again. Also replace the bare `1 << 30` / `1 << 31` literals with named constants. Fixes ElementsProject#292
Member
|
Nice. Principled fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pegin and issuance flags are stored in the high bits of the PSET
previous_output_index, but they are not part of the outpoint itself: Elements Core keeps them separate in memory and only re-adds them when serializing.Input::issuance_idswas computing the asset entropy over the flagged index, so any new issuance round-tripped through a PSET derived different asset and token IDs than Elements does.extract_txalready masked the flags, but did so inline. AddInput::previous_outpoint, which strips them (leaving the all-1's coinbase index alone, as it carries no flags), and use it from both places so the two cannot drift apart again. Also replace the bare1 << 30/1 << 31literals with named constants.Fixes #292